Skip to content

Conversation

@ORybak5
Copy link
Contributor

@ORybak5 ORybak5 commented Sep 8, 2025

What

Prevent a duplicate medication request to be pulled as a non-consultation item

Why

If one medication request has been processed we don't need to pull another one (as a non-consultation item) that is based on the fist medication request.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@ORybak5 ORybak5 requested a review from a team as a code owner September 8, 2025 10:35
@ORybak5 ORybak5 changed the title NIAD-3393: missing medication NIAD-3393: missing medication [DO NOT MERGE] Sep 8, 2025
@ORybak5 ORybak5 changed the title NIAD-3393: missing medication [DO NOT MERGE] NIAD-3393: missing medication Sep 9, 2025
@ORybak5 ORybak5 changed the title NIAD-3393: missing medication NIAD-3393: Prevent a duplicate medication request to be pulled as a non-consultation item Sep 9, 2025
@github-actions
Copy link

Looks good. All 17 mutations in this change were killed.

class surviving killed
💯uk.nhs.adaptors.gp2gp.ehr.mapper.NonConsultationResourceMapper 0 17

See https://pitest.org

@sonarqubecloud
Copy link

@ORybak5 ORybak5 enabled auto-merge (squash) September 24, 2025 14:13
@ORybak5 ORybak5 merged commit 12f8e25 into main Sep 24, 2025
15 checks passed
@ORybak5 ORybak5 deleted the NIAD-3393 branch September 24, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants